chenBright opened a new pull request, #2556: URL: https://github.com/apache/brpc/pull/2556
### What problem does this PR solve? Issue Number: Problem Summary: CachedReader::get_value中fn没有在锁内执行，第一次执行get_value的时候，可能会读到_cache的初始值。由于_cache没有显式初始化，而且实际的类型（如ProcMemory、ProcStat）没有实现默认构造函数，所以成员变量的值是随机值。现对于随机值，值为0，让人更好理解一些。 https://github.com/apache/brpc/blob/24fc31eaa56d8b522975ca41ed012faf6cf77438/src/bvar/default_variables.cpp#L147-L163 ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): - Breaking backward compatibility(向后兼容性): --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
