wwbmmm commented on code in PR #2560:
URL: https://github.com/apache/brpc/pull/2560#discussion_r1533283281
##########
src/brpc/socket_inl.h:
##########
@@ -176,17 +119,25 @@ inline void Socket::ReAddress(SocketUniquePtr* ptr) {
}
inline int Socket::AddressFailedAsWell(SocketId id, SocketUniquePtr* ptr) {
+ return AddressImpl(id, true, ptr);
+}
+
+inline int Socket::AddressImpl(SocketId id,
Review Comment:
> Socket的health check和revive机制不够通用，不好抽象，所以VersionedRefWithId没有实现health
check和revive机制。目前Socket还是使用自己的versioned_ref和id逻辑，不复用VersionedRefWithId的逻辑。
可否让Socket使用VersionedRefWithId的versioned_ref和id成员来实现health check和revive机制？
感觉Socket自己再定义一个versioned_ref和id成员怪怪的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
