chenBright commented on code in PR #2577:
URL: https://github.com/apache/brpc/pull/2577#discussion_r1564505378
##########
src/brpc/http_header.h:
##########
@@ -80,24 +85,39 @@ class HttpHeader {
// Return pointer to the value, NULL on not found.
// NOTE: If the key is "Content-Type", `GetHeader("Content-Type")'
// (case-insensitive) is equal to `content_type()'.
- const std::string* GetHeader(const char* key) const
- { return _headers.seek(key); }
- const std::string* GetHeader(const std::string& key) const
- { return _headers.seek(key); }
+ const std::string* GetHeader(const char* key) const;
+ const std::string* GetHeader(const std::string& key) const;
+
+ std::vector<const std::string*> GetAllSetCookieHeader() const;
Review Comment:
` const std::string* GetHeader(const std::string& key) const;`
map的key是string，支持调用方使用string来调用GetHeader，减少一次string的构造
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
