yozhao commented on PR #2651: URL: https://github.com/apache/brpc/pull/2651#issuecomment-2128873260
嗯 大意了，改过来了。 lei he ***@***.***> 于2024年5月24日周五 14:16写道： > ***@***.**** commented on this pull request. > ------------------------------ > > In src/brpc/span.h > <https://github.com/apache/brpc/pull/2651#discussion_r1612875583>: > > > @@ -206,6 +206,7 @@ void AnnotateSpan(const char* fmt, ...); > > class SpanFilter { > public: > + virtual ~SpanFilter() = 0; > > 定义成纯虚函数最后链接会出错吧。。 virtual ~SpanFilter() = default 比较好 > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/brpc/pull/2651#pullrequestreview-2075880770>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAVHRJ342JMQKAAVVHLD323ZD3LKXAVCNFSM6AAAAABIG43P7GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZVHA4DANZXGA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
