MJY-HUST commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1618964917
##########
test/bthread_key_unittest.cpp:
##########
@@ -385,19 +388,21 @@ TEST(KeyTest, using_pool) {
ASSERT_EQ(0, bthread_start_urgent(&bth, &attr, pool_thread, &bth_data));
ASSERT_EQ(0, bthread_join(bth, NULL));
ASSERT_EQ(0, bth_data.seq);
- ASSERT_EQ(1, bthread_keytable_pool_size(&pool));
- PoolData bth2_data = { key, &bth_data, 0, 3 };
+ PoolData bth2_data = { key, NULL, 0, 3 };
bthread_t bth2;
ASSERT_EQ(0, bthread_start_urgent(&bth2, &attr2, pool_thread, &bth2_data));
ASSERT_EQ(0, bthread_join(bth2, NULL));
ASSERT_EQ(0, bth2_data.seq);
- ASSERT_EQ(1, bthread_keytable_pool_size(&pool));
ASSERT_EQ(0, bthread_keytable_pool_destroy(&pool));
-
- EXPECT_EQ(bth_data.end_seq, bth_data.seq);
- EXPECT_EQ(0, bth2_data.seq);
+ if(use_same_keytable) {
Review Comment:
ok，加上了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
