wwbmmm commented on code in PR #2655: URL: https://github.com/apache/brpc/pull/2655#discussion_r1624030452
########## src/brpc/server.cpp: ########## @@ -123,6 +123,8 @@ const int INITIAL_CERT_MAP = 64; // compilation units is undefined. const int s_ncore = sysconf(_SC_NPROCESSORS_ONLN); +DEFINE_uint64(latency_scale_factor, 1, "latency scale factor, used by method status, etc., latency_us = latency * latency_scale_factor"); Review Comment: I think this gflag can be directly defined in `latency_recorder.cpp`, so that it doesn't need to be passed through so many layers of parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
