oathdruid commented on issue #2671:
URL: https://github.com/apache/brpc/issues/2671#issuecomment-2232605089
can we make RpcPBMessages a virtual class?
implementations can track arena / other memory resource, along with
messages. like this
```
class RpcPBMessageManager {
public:
virtual ::std::unique_ptr<RpcPBMessages> Get(const
google::protobuf::Service& service,
const google::protobuf::MethodDescriptor& method) = 0;
virtual void Return(::std::unique_ptr<RpcPBMessages> protobuf_message) =
0;
};
class CustomRpcPBMessages : public RpcPBMessages {
MemoryResource resource;
};
```
this simplify lookup from Message* to Arena / MemoryResource they belong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
