This is an automated email from the ASF dual-hosted git repository.
wwbmmm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 15b52c59 Remove Incorrect log in RemoveServersInBatch (#2932)
15b52c59 is described below
commit 15b52c59dd3a8c5b1b803f1ad9f0b13a9164dc81
Author: Bright Chen <[email protected]>
AuthorDate: Mon Mar 31 22:24:52 2025 +0800
Remove Incorrect log in RemoveServersInBatch (#2932)
---
src/brpc/policy/consistent_hashing_load_balancer.cpp | 3 ---
src/brpc/policy/dynpart_load_balancer.cpp | 3 ---
src/brpc/policy/randomized_load_balancer.cpp | 3 ---
src/brpc/policy/round_robin_load_balancer.cpp | 3 ---
src/brpc/policy/weighted_round_robin_load_balancer.cpp | 3 ---
5 files changed, 15 deletions(-)
diff --git a/src/brpc/policy/consistent_hashing_load_balancer.cpp
b/src/brpc/policy/consistent_hashing_load_balancer.cpp
index c18c9a34..2560d8f2 100644
--- a/src/brpc/policy/consistent_hashing_load_balancer.cpp
+++ b/src/brpc/policy/consistent_hashing_load_balancer.cpp
@@ -267,9 +267,6 @@ size_t ConsistentHashingLoadBalancer::RemoveServersInBatch(
const size_t ret = _db_hash_ring.ModifyWithForeground(RemoveBatch,
servers, &executed);
CHECK(ret % _num_replicas == 0);
const size_t n = ret / _num_replicas;
- LOG_IF(ERROR, n != servers.size())
- << "Fail to RemoveServersInBatch, expected " << servers.size()
- << " actually " << n;
return n;
}
diff --git a/src/brpc/policy/dynpart_load_balancer.cpp
b/src/brpc/policy/dynpart_load_balancer.cpp
index 579ca7dd..ad3cbbcb 100644
--- a/src/brpc/policy/dynpart_load_balancer.cpp
+++ b/src/brpc/policy/dynpart_load_balancer.cpp
@@ -95,9 +95,6 @@ size_t DynPartLoadBalancer::AddServersInBatch(
size_t DynPartLoadBalancer::RemoveServersInBatch(
const std::vector<ServerId>& servers) {
const size_t n = _db_servers.Modify(BatchRemove, servers);
- LOG_IF(ERROR, n != servers.size())
- << "Fail to RemoveServersInBatch, expected " << servers.size()
- << " actually " << n;
return n;
}
diff --git a/src/brpc/policy/randomized_load_balancer.cpp
b/src/brpc/policy/randomized_load_balancer.cpp
index cac695af..353074eb 100644
--- a/src/brpc/policy/randomized_load_balancer.cpp
+++ b/src/brpc/policy/randomized_load_balancer.cpp
@@ -97,9 +97,6 @@ size_t RandomizedLoadBalancer::AddServersInBatch(
size_t RandomizedLoadBalancer::RemoveServersInBatch(
const std::vector<ServerId>& servers) {
const size_t n = _db_servers.Modify(BatchRemove, servers);
- LOG_IF(ERROR, n != servers.size())
- << "Fail to RemoveServersInBatch, expected " << servers.size()
- << " actually " << n;
return n;
}
diff --git a/src/brpc/policy/round_robin_load_balancer.cpp
b/src/brpc/policy/round_robin_load_balancer.cpp
index c7dd972d..0bc2f58b 100644
--- a/src/brpc/policy/round_robin_load_balancer.cpp
+++ b/src/brpc/policy/round_robin_load_balancer.cpp
@@ -97,9 +97,6 @@ size_t RoundRobinLoadBalancer::AddServersInBatch(
size_t RoundRobinLoadBalancer::RemoveServersInBatch(
const std::vector<ServerId>& servers) {
const size_t n = _db_servers.Modify(BatchRemove, servers);
- LOG_IF(ERROR, n != servers.size())
- << "Fail to RemoveServersInBatch, expected " << servers.size()
- << " actually " << n;
return n;
}
diff --git a/src/brpc/policy/weighted_round_robin_load_balancer.cpp
b/src/brpc/policy/weighted_round_robin_load_balancer.cpp
index 2a98e7fb..598d7dc0 100644
--- a/src/brpc/policy/weighted_round_robin_load_balancer.cpp
+++ b/src/brpc/policy/weighted_round_robin_load_balancer.cpp
@@ -150,9 +150,6 @@ size_t WeightedRoundRobinLoadBalancer::AddServersInBatch(
size_t WeightedRoundRobinLoadBalancer::RemoveServersInBatch(
const std::vector<ServerId>& servers) {
const size_t n = _db_servers.Modify(BatchRemove, servers);
- LOG_IF(ERROR, n != servers.size())
- << "Fail to RemoveServersInBatch, expected " << servers.size()
- << " actually " << n;
return n;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
