old-bear opened a new pull request, #3105: URL: https://github.com/apache/brpc/pull/3105
### What problem does this PR solve? Issue Number: Problem Summary: When sending large packet under SSL, brpc could stuck as data still resides in BIO buffer. ### What is changed and the side effects? Changed: Disable BIO for SSL for 2 reasons: 1. The current implementation makes it very hard to handle EAGAIN from both SSL_write and BIO_flush. 2. BIO is optional and kind of outdate for modern TCP, which already has buffer mechanism Side effects: - Performance effects: Should be no impact - Breaking backward compatibility: No --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
