wwbmmm commented on code in PR #3213:
URL: https://github.com/apache/brpc/pull/3213#discussion_r2758167608
##########
src/brpc/selective_channel.cpp:
##########
@@ -344,7 +344,9 @@ int Sender::IssueRPC(int64_t start_realtime_us) {
sub_cntl->set_request_code(_main_cntl->request_code());
// Forward request attachment to the subcall
sub_cntl->request_attachment().append(_main_cntl->request_attachment());
- sub_cntl->http_request() = _main_cntl->http_request();
+ if (PROTOCOL_HTTP == _main_cntl->request_protocol()) {
Review Comment:
maybe this can also apply to PROTOCOL_H2
##########
src/brpc/parallel_channel.cpp:
##########
@@ -724,6 +724,9 @@ void ParallelChannel::CallMethod(
ParallelChannelDone::SubDone* sd = d->sub_done(j++);
// Forward the attachment to each sub call
sd->cntl.request_attachment().append(cntl->request_attachment());
+ if (PROTOCOL_HTTP == cntl->request_protocol()) {
Review Comment:
The current ParallelChannel is not friendly to http protocol if user want to
set different http request params for different sub call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
