darion-yaphet opened a new pull request, #3262:
URL: https://github.com/apache/brpc/pull/3262
The configuration script previously ran silently with no visible output,
making it hard to tell whether it was working or what it detected. Add colored
progress messages for each stage: system info, dependency discovery, output
file generation, and a final configuration summary.
### What problem does this PR solve?
Issue Number: resolve
Problem Summary: Running config_brpc.sh produces no visible output during
configuration, leaving users unable to tell if the script is working, what
dependencies were detected, or whether configuration succeeded.
### What is changed and the side effects?
Changed:
- Added colored progress output to config_brpc.sh covering four stages:
system/compiler info, dependency discovery (openssl, gflags, protobuf, leveldb,
protoc),
output file generation, and a final configuration summary.
- No logic changes — only printf statements were added to stdout. All
existing error messages to stderr remain unchanged.
Side effects:
- Performance effects: Negligible. Only adds a few printf calls.
- Breaking backward compatibility: None. The script's exit codes,
generated config.mk, and src/butil/config.h are identical. Scripts that parse
stderr are unaffected since all new output goes to stdout.
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
