hjwsm1989 commented on PR #3283: URL: https://github.com/apache/brpc/pull/3283#issuecomment-4319874531
@chenBright 谢谢 review，已按你的建议改成回退 `LocalityAwareLoadBalancer` 一侧的 #3268 改动（`Weight::Update::end_time_us`、`Describe::now` 与 include 注释），不动 `Channel::CallMethod` / `Controller::OnVersionedRPCReturned` 的调用方，这样 `Controller::_begin_time_us` / `latency_us()` 的墙上时钟语义保持原样。 新增的 `la_records_latency_with_consistent_time_source` 测试也对应调整：直接用 `butil::gettimeofday_us()` 作为 `CallInfo::begin_time_us`（匹配现有 caller），断言 `_avg_latency > 0` —— 如果将来再有人把 `Weight::Update` 的时钟切走，或者哪个 caller 漂到别的时钟域，都会被这个测试抓到。 force-pushed 到 `2c285ff2`，PR description 也同步更新到了新的 revert 思路下。再麻烦你看一下，谢谢！ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
