wwbmmm commented on code in PR #3310: URL: https://github.com/apache/brpc/pull/3310#discussion_r3328017549
########## src/brpc/policy/mysql_auth/mysql_auth_handshake.h: ########## @@ -0,0 +1,131 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// Codec for the four MySQL connection-phase packets the client touches +// during authentication. All functions operate on raw packet payloads +// (without the 4-byte packet header); the caller is responsible for +// framing. Specifications: +// HandshakeV10: +// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase_packets_protocol_handshake_v10.html +// HandshakeResponse41: +// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase_packets_protocol_handshake_response.html +// AuthSwitchRequest / AuthMoreData: +// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase_packets_protocol_auth_switch_request.html +// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase_packets_protocol_auth_more_data.html + +#ifndef BRPC_POLICY_MYSQL_AUTH_MYSQL_AUTH_HANDSHAKE_H +#define BRPC_POLICY_MYSQL_AUTH_MYSQL_AUTH_HANDSHAKE_H + +#include <stdint.h> + +#include <string> + +#include "butil/strings/string_piece.h" + +namespace brpc { +namespace policy { +namespace mysql_auth { Review Comment: I think the namespace name and folder name can be just `mysql`. You may add other mysql components' code (not belong to the auth component) in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
