Felix-Gong commented on code in PR #3316:
URL: https://github.com/apache/brpc/pull/3316#discussion_r3329868494
##########
src/brpc/socket.cpp:
##########
@@ -2146,6 +2154,10 @@ ssize_t Socket::DoRead(size_t size_hint) {
BIO_fd_non_fatal_error(saved_errno) != 0 ||
nr < 0;
PLOG_IF(WARNING, is_fatal_error) << "Fail to read from ssl_fd=" <<
fd();
+ if (is_fatal_error) {
Review Comment:
The caller only checks errno == EAGAIN and errno == EINTR for retry logic.
ESSL matches neither, so control flow is unchanged — it still enters
SetFailed().
The only difference is the error message. But I'll revert this change to
keep the fix minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
