darion-yaphet commented on code in PR #3377: URL: https://github.com/apache/brpc/pull/3377#discussion_r3552670304
########## CMakeLists.txt: ########## @@ -15,7 +15,7 @@ # specific language governing permissions and limitations # under the License. -cmake_minimum_required(VERSION 2.8.12) Review Comment: I understand the concern about compatibility, but CMake 3.16 is actually not very radical. CMake 2.x was quite an old era. The main line has moved to 4.x now, and CMake 3 is the mainstream baseline for many years past. The main benefits of upgrading to CMake 3 are not "keeping up with the latest trends", but rather the ability to use modern CMake syntax: target-based configuration, target_compile_features, target_link_options, generator expressions, better dependency discovery and cross-platform behavior. These features can avoid the pollution of global CFLAGS/LDFLAGS, allowing includes, macro definitions, and link parameters to be propagated by target. This makes the project easier to maintain and less likely to fail due to differences in the local environment. Overall, 3.16 represents a relatively conservative modern baseline, not a radical upgrade. ########## CMakeLists.txt: ########## @@ -15,7 +15,7 @@ # specific language governing permissions and limitations # under the License. -cmake_minimum_required(VERSION 2.8.12) Review Comment: > The upgraded version seems too high, is it necessary? I understand the concern about compatibility, but CMake 3.16 is actually not very radical. CMake 2.x was quite an old era. The main line has moved to 4.x now, and CMake 3 is the mainstream baseline for many years past. The main benefits of upgrading to CMake 3 are not "keeping up with the latest trends", but rather the ability to use modern CMake syntax: target-based configuration, target_compile_features, target_link_options, generator expressions, better dependency discovery and cross-platform behavior. These features can avoid the pollution of global CFLAGS/LDFLAGS, allowing includes, macro definitions, and link parameters to be propagated by target. This makes the project easier to maintain and less likely to fail due to differences in the local environment. Overall, 3.16 represents a relatively conservative modern baseline, not a radical upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
