chenBright commented on code in PR #3368: URL: https://github.com/apache/brpc/pull/3368#discussion_r3566519631
########## src/butil/endpoint.h: ########## @@ -141,6 +141,9 @@ int tcp_connect(const EndPoint& server, int* self_port, int connect_timeout_ms); // To enable SO_REUSEPORT for the whole program, enable gflag -reuse_port // Returns the socket descriptor, -1 otherwise and errno is set. int tcp_listen(EndPoint ip_and_port); +// If `before_listen' is not NULL, it will be called before bind/listen. +typedef void (*BeforeListenCallback)(int fd); Review Comment: Making BeforeListenCallback a std::function type would be more appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
