ubeddulla commented on PR #3376: URL: https://github.com/apache/brpc/pull/3376#issuecomment-4954662139
Added tests. flat_map_unittest's to_lower case now sweeps all 256 byte values through ascii_tolower as a `char` (the way header/HPACK callers reach it) and checks each against ::tolower, so the >= 0x80 promotion path is covered. brpc_uri_unittest gets a high_bit_bytes case that runs UTF-8 bytes through the host/path/query/fragment in both SetHttpURL and ParseURL. Both trip the overflow read under ASan before the cast and pass after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
