Copilot commented on code in PR #3389: URL: https://github.com/apache/brpc/pull/3389#discussion_r3586728635
########## src/bthread/context.cpp: ########## @@ -617,7 +617,7 @@ __asm ( __asm ( ".cpu generic+fp+simd\n" ".text\n" -".align 2\n" +".align 6\n" ".global bthread_jump_fcontext\n" Review Comment: `.align` is target/assembler-specific (some assemblers treat the argument as a byte count, others as a power-of-two). Since the intent here is 64-byte alignment, consider using an explicit directive like `.p2align 6` (or `.balign 64`) to avoid ambiguity and improve portability across GNU as vs clang IAS. ########## src/bthread/context.cpp: ########## @@ -689,7 +689,7 @@ __asm ( __asm ( ".cpu generic+fp+simd\n" ".text\n" -".align 2\n" +".align 6\n" ".global bthread_make_fcontext\n" Review Comment: Same as above: if the goal is 64-byte alignment, using `.p2align 6` (or `.balign 64`) is more explicit than `.align 6` and avoids assembler-specific interpretation differences. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
