Felix-Gong commented on PR #3396: URL: https://github.com/apache/brpc/pull/3396#issuecomment-5029381507
Addressed all 3 review comments: 1. **BUILD.bazel - modp_b64_rvv.cc restored**: \`modp_b64.cc\` calls \`rvv_modp_b64_encode/decode\` when \`__riscv_vector\` is enabled, so the RVV implementation file must be compiled. This was an oversight inherited from PR #3390. 2. **string_compare_rvv.cc header updated**: Now reflects both \`rvv_memcmp\` and \`rvv_memchr\` implementations. 3. **string_piece.cc explicit cast**: Added \`static_cast<size_t>()\` around pointer difference to match \`findT\` style and avoid sign-conversion warnings. CI running on the new commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
