chenBright commented on code in PR #3304:
URL: https://github.com/apache/brpc/pull/3304#discussion_r3708971714
##########
src/brpc/rdma/rdma_endpoint.h:
##########
@@ -281,6 +281,13 @@ friend int v3_wire::WriteV3Hello(RdmaEndpoint*, const
RdmaHello&);
// QP reached RTS (filled in BringUpQp).
butil::optional<ibv_ece> _outgoing_ece;
+ // MTU payload to advertise in the next local hello:
+ // Client: the locally queried active MTU (filled
+ // before C_HELLO_SEND);
+ // Server: the negotiated MTU = min(local_active_mtu, client_mtu)
+ // (filled in BringUpQp).
+ butil::optional<uint32_t> _outgoing_mtu;
Review Comment:
Why use uint32_t instead of ibv_mtu?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
