darion-yaphet commented on code in PR #3419:
URL: https://github.com/apache/brpc/pull/3419#discussion_r3718302662
##########
src/butil/type_traits.h:
##########
@@ -373,11 +373,11 @@ template <typename>
struct result_of;
template <typename F, typename... Args>
struct result_of<F(Args...)> : std::invoke_result<F, Args...> {};
-#elif __cplusplus >= 201103L
+#elif __cplusplus >= 201402L
template <typename F>
using result_of = std::result_of<F>;
#else
-#error Only C++11 or later is supported.
+#error Only C++14 or later is supported.
Review Comment:
Agreed
The C++14 baseline is already enforced by the build system; std::result_of
itself doesn’t need a C++14 gate. Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
