chenBright opened a new pull request, #3427:
URL: https://github.com/apache/brpc/pull/3427
### What problem does this PR solve?
Issue Number:
Problem Summary:
When bRPC is built as an external Bazel dependency, `brpc_proto_library`
passes `"."` to
the `includes` attribute of `cc_library`. In the root package of the
external repository, `"."`
resolves to the workspace root, causing Bazel to reject the target because
it would expose
every file in the workspace to the rule and all its transitive dependents:
```text
Traceback (most recent call last):
File "/virtual_builtins_bzl/common/cc/cc_library.bzl", line 61, column
56, in _cc_library_impl
File "/virtual_builtins_bzl/common/cc/cc_helper.bzl", line 1077, column
17, in _system_include_dirs
Error in fail: attribute includes: '.' resolves to the workspace root, which
would allow this rule and all of its transitive dependents to include any file
in your workspace. Please include only what you need
```
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects:
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
