chenBright commented on code in PR #3421:
URL: https://github.com/apache/brpc/pull/3421#discussion_r3726689640
##########
src/brpc/controller.cpp:
##########
@@ -183,7 +183,7 @@ static void CreateIgnoreAllRead() { s_ignore_all_read = new
IgnoreAllRead; }
// you don't have to set the fields to initial state after deletion since
// they'll be set uniformly after this method is called.
void Controller::ResetNonPods() {
- if (auto span = _span.lock()) {
+ if (auto span = _span) {
Review Comment:
Just use `_span` directly please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
