chenBright commented on PR #3423: URL: https://github.com/apache/brpc/pull/3423#issuecomment-5232099105
> Will this affect performance? This will speed up the EventDispatcher's scheduling, and no obvious side effects were observed. When FLAGS_enable_bthread_priority_queue is false (the default), bthread_start_urgent from the EventDispatcher goes through ready_to_run_in_worker / ready_to_run, which would signals a worker. When it is true, the EventDispatcher bthread is pushed into the global priority queue and can only be picked up by another worker via steal_task(), while idle workers stay parked until signal_task() wakes them. So the signal is necessary to get the EventDispatcher rescheduled quickly, which is exactly the purpose of the priority queue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
