zchuango commented on code in PR #3475:
URL: https://github.com/apache/brpc/pull/3475#discussion_r3835824825
##########
CMakeLists.txt:
##########
@@ -351,7 +352,7 @@ set(DYNAMIC_LIB
${CMAKE_THREAD_LIBS_INIT}
${THRIFT_LIB}
dl
- z)
+ ZLIB::ZLIB)
Review Comment:
brpc.pc has historically represented zlib as the portable linker name -lz,
together with the other manually maintained private dependencies. Translating a
CMake imported target into relocatable pkg-config metadata is outside the scope
of this header-resolution fix; using an absolute library path would also make
the generated .pc file non-relocatable. We can address pkg-config dependency
modeling separately if a concrete static-linking failure is identified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
