bzs1118 commented on code in PR #3480:
URL: https://github.com/apache/brpc/pull/3480#discussion_r3843698286
##########
src/brpc/transport.h:
##########
@@ -51,6 +51,11 @@ class Transport {
virtual void QueueMessage(InputMessageClosure& input_msg, int*
num_bthread_created, bool last_msg) = 0;
virtual void Debug(std::ostream &os) = 0;
+ // Returns true if OnNewMessages should stop its read loop immediately
+ // (e.g., RDMA transport after handshake completes and edge trigger
+ // is switched to OnNewDataFromTcp). Default: never stop.
+ virtual bool ShouldStopReading() const { return false; }
Review Comment:
If ABI stability becomes a requirement in the future, this can be refactored
to use a non-virtual capability query, but for now I think it's OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
