FangzuoZhang commented on code in PR #3484:
URL: https://github.com/apache/brpc/pull/3484#discussion_r3860319062
##########
src/brpc/ubshm_transport.cpp:
##########
@@ -174,6 +174,35 @@ void UBShmTransport::QueueMessage(InputMessageClosure&
input_msg,
}
}
+void UBShmTransport::QueueMessages(InputMessageBatch* input_msgs,
+ int* num_bthread_created, bool last_msg) {
+ CHECK(!last_msg);
+ if (!input_msgs || input_msgs->empty()) {
+ delete input_msgs;
+ return;
+ }
+ if (ubring::FLAGS_ub_disable_bthread) {
+ input_msgs->Run();
+ delete input_msgs;
+ return;
+ }
Review Comment:
Removed the unused `last_msg` parameter from the batch scheduling interface.
The final RDMA/UBRing message continues to use the single-message path.
##########
src/brpc/rdma_transport.cpp:
##########
@@ -183,6 +183,34 @@ void RdmaTransport::QueueMessage(InputMessageClosure&
input_msg,
}
}
+void RdmaTransport::QueueMessages(InputMessageBatch* input_msgs,
+ int* num_bthread_created, bool last_msg) {
+ CHECK(!last_msg || rdma::FLAGS_rdma_use_polling);
+ if (!input_msgs || input_msgs->empty()) {
+ delete input_msgs;
+ return;
+ }
+ if (rdma::FLAGS_rdma_disable_bthread) {
+ input_msgs->Run();
+ delete input_msgs;
+ return;
+ }
Review Comment:
Removed the unused `last_msg` parameter from the batch scheduling interface.
The final RDMA/UBRing message continues to use the single-message path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
