wasphin opened a new pull request, #3493:
URL: https://github.com/apache/brpc/pull/3493
### What problem does this PR solve?
Issue Number: N/A
Problem Summary:
`StreamAccept` creates one response stream for every stream identifier
declared
by a request, without limiting the number created by a single RPC.
### What is changed and the side effects?
Changed:
- Add `stream_max_streams_per_request` with a default value of 64.
- Reject requests exceeding the limit before creating any response streams.
- Cover the boundary, rejection, and a subsequent valid request over the same
client/server connection.
Side effects:
- Performance effects: one constant-time count check per `StreamAccept` call.
- Breaking backward compatibility: applications accepting more than 64
streams in one RPC must raise `stream_max_streams_per_request`.
---
### Check List:
- [x] Please make sure your changes are compilable.
- [x] When providing us with a new feature, it is best to add related tests.
- [x] Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
