chenBright commented on code in PR #3500:
URL: https://github.com/apache/brpc/pull/3500#discussion_r3885184926
##########
test/BUILD.bazel:
##########
@@ -24,7 +24,12 @@ COPTS = [
"-Wno-unused-parameter",
"-fno-omit-frame-pointer",
"-fno-access-control",
-]
+] + select({
+ # The thrift framed protocol (and the unit test that exercises it) is only
+ # compiled when the build has Thrift support enabled, matching src/BUILD.
+ "//bazel/config:brpc_with_thrift": ["-DENABLE_THRIFT_FRAMED_PROTOCOL=1"],
+ "//conditions:default": [],
+})
Review Comment:
It seems this select is not needed. unit test targets will inherit this
definition of bRPC source targets automatically.
https://github.com/apache/brpc/blob/4a429cdc2153eff616902edfd2349823d6d7c5b5/BUILD.bazel#L45-L48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
