darion-yaphet opened a new pull request, #3504: URL: https://github.com/apache/brpc/pull/3504
### What problem does this PR solve? Issue Number: N/A Problem Summary: `bthread.h` declared POSIX-style barrier APIs (`bthread_barrier_init/destroy/wait`) and rwlock attribute APIs (`bthread_rwlockattr_init/destroy/getkind_np/setkind_np`) that were never defined in `libbrpc`. Compiling against the headers succeeded, then linking failed with `undefined reference`. The headers advertised an API that the library does not provide. ### What is changed and the side effects? Changed: - Remove unimplemented `bthread_barrier_*` declarations and the unused `bthread_barrier_t` / `bthread_barrierattr_t` types. - Remove unimplemented `bthread_rwlockattr_*` declarations. - Keep `bthread_rwlockattr_t` because it is still the argument type of the implemented `bthread_rwlock_init()`. - Document that `bthread_rwlock_init()` currently ignores `attr`. Side effects: - Performance effects: none. - Breaking backward compatibility: source-incompatible only for code that called these never-linked symbols. Working programs that already linked against brpc could not have been using them. `bthread_rwlock_init()` signature is unchanged. --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
