wasphin opened a new pull request, #3508: URL: https://github.com/apache/brpc/pull/3508
### What problem does this PR solve? Issue Number: resolve Problem Summary: An RTMP service may reject a `createStream` request by returning a null stream. If writing the rejection response also fails, the error path accesses the null stream while attempting to notify its failure callback. ### What is changed and the side effects? Changed: Only notify the stream failure callback when a stream was created. A rejected request with a failed response now closes the connection without accessing the missing stream. Side effects: - Performance effects: None. - Breaking backward compatibility: No. --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
