Copilot commented on code in PR #3515:
URL: https://github.com/apache/brpc/pull/3515#discussion_r3906520788
##########
src/brpc/policy/rtmp_protocol.cpp:
##########
@@ -879,8 +879,7 @@ void RtmpContext::ClearChunkStream(uint32_t cs_id) {
LOG(ERROR) << "chunk_stream_id=" << cs_id << " does not exist";
return;
Review Comment:
`AbortChunkStream()` is documented (and used) as a best-effort reset of an
existing stream, but it logs `LOG(ERROR)` when the target chunk stream doesn't
exist. An Abort message can legitimately reference a stream that has never been
created locally, and treating that as an error can spam logs and look like a
server fault. Consider silently ignoring missing streams (or downgrading to
`VLOG(1)`/`LOG(WARNING)`) while keeping the invalid-id check as an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
