chenBright commented on code in PR #3557:
URL: https://github.com/apache/brpc/pull/3557#discussion_r4069188451
##########
src/bvar/mvariable.cpp:
##########
@@ -189,6 +198,7 @@ int MVariableBase::expose_impl(const butil::StringPiece&
prefix,
if (entry == nullptr) {
entry = &m[_name];
entry->ref = _ref;
Review Comment:
Correct that the two maps stay separate, and that is deliberate. The
guarantee now lives in `PrometheusMetricsDumper`, which is the only place that
sees every name at once: the bvar pass, the mbvar pass, and the names the
exporter itself makes up, such as `_avg_latency` and the summary `_sum`, which
no variable is ever exposed under. An expose time registry cannot cover those
without duplicating the exporter naming rules inside bvar, and that duplication
is exactly what left the gap you reported on
[latency_recorder.cpp](https://github.com/apache/brpc/pull/latency_recorder.cpp).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
