wasphin opened a new pull request, #3562: URL: https://github.com/apache/brpc/pull/3562
### What problem does this PR solve? Problem Summary: `ButexTest.stop_after_running` assumes that stopping and joining a task finishes within 25 ms of a 10 ms sleep. The assertion is sensitive to scheduler delays and has failed in CI exactly at the 25 ms boundary. The waiter already verifies that `bthread_stop()` interrupts `butex_wait()` with `EINTR`, which is the behavior under test. ### What is changed and the side effects? Changed: Remove the wall-clock timing assertion and its timer while retaining the `EINTR`, stop, join, and repeated-stop checks. Side effects: - Performance effects: None. - Breaking backward compatibility: No. --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
