chenBright opened a new pull request, #3563: URL: https://github.com/apache/brpc/pull/3563
### What problem does this PR solve? Issue Number: resolve Problem Summary: `std::numeric_limits<T>::min()` is the smallest positive normalized value for floating-point types, not the lowest representable value. As a result, `bvar::Maxer<double>` could incorrectly report a positive value when only negative values were recorded. ### What is changed and the side effects? Changed: Use `std::numeric_limits<T>::lowest()` as the default value for `Maxer`. Side effects: - Performance effects: - Breaking backward compatibility: --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
