songgaoye opened a new pull request, #3620:
URL: https://github.com/apache/brpc/pull/3620
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
`MPSCQueue` stores each queued value in `ManualConstructor<T>`, whose
destructor does not automatically destroy the contained object.
When a node is dequeued or discarded during queue destruction, the node is
returned to its allocator without destroying its `T` value. For non-trivial
types, this skips destructors and can leak resources held by queued elements.
### What is changed and the side effects?
Changed:
- Destroy the contained queue element before returning its node to the
allocator.
- Add regression tests covering both pending elements destroyed with the
queue
and elements destroyed after dequeue.
Side effects:
- Performance effects:
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
