sahvx655-wq commented on PR #3625: URL: https://github.com/apache/brpc/pull/3625#issuecomment-6359604068
Agreed on both, and I'll leave the two Copilot threads as they are. Copying from `*this` is what keeps `width`/`height` stable across a header with no SPS: they're only ever written inside `ParseSPS`, so a fresh record would reset them to 0 on exactly the headers `TsWriter` goes on reading them from. Everything else is overwritten before any later return (profile/level/`length_size_minus1` at the top of `Parse()`, both lists cleared before refill), so there's no other field that can carry over. In the test, the `0x4d` profile in the rejected headers is what gives the post-failure `avc_profile` assertions something to catch; with the bytes identical to `good_head` they'd have passed against the previous revision as well, and the truncated case was the one that failed there (66 vs 77). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
