chenBright commented on code in PR #3535:
URL: https://github.com/apache/brpc/pull/3535#discussion_r4357875105
##########
src/brpc/global.cpp:
##########
@@ -438,12 +438,16 @@ static void GlobalInitializeOrDieImpl() {
}
// Protocols
- Protocol rdma_handshake_protocol = {
- ParseRdmaHandshake, nullptr, nullptr,
- ProcessRdmaHandshake, nullptr,
+ Protocol transport_handshake_protocol = {
+ ParseTransportHandshake, nullptr, nullptr,
+ ProcessTransportHandshake, nullptr,
nullptr, nullptr, nullptr,
CONNECTION_TYPE_ALL, "rdma_handshake" };
- if (RegisterProtocol(PROTOCOL_RDMA_HANDSHAKE, rdma_handshake_protocol) !=
0) {
+ // Retain the existing enum value and registered name to avoid changing
+ // public protocol identifiers while widening the implementation from RDMA
+ // to all transport upgrades.
+ if (RegisterProtocol(PROTOCOL_RDMA_HANDSHAKE,
Review Comment:
@Spicy-cream Please take a look at this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
