two-headBoy commented on PR #3633: URL: https://github.com/apache/brpc/pull/3633#issuecomment-6627796610
Thanks for the reviews. I agree the root problem is the design: making `push_rq()` an implicit scheduling point breaks existing assumptions of `bthread_start_background()` and its callers. The follow-up fixes only address individual consequences of this change. I’ll abandon this implementation and close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
