chenBright commented on code in PR #3713:
URL: https://github.com/apache/brpc/pull/3713#discussion_r4481419643
##########
src/butil/find_cstr.cpp:
##########
@@ -21,6 +21,6 @@
namespace butil {
-thread_local StringMapThreadLocalTemp tls_stringmap_temp = { false, {} };
+BUTIL_THREAD_LOCAL(StringMapThreadLocalTemp, tls_stringmap_temp, { false, {}
});
Review Comment:
`find_cstr.cpp` includes its own header, `find_cstr.h`, which explicitly
includes `butil/thread_local.h` and requires it for `thread_atexit`. This
dependency is intentional, and the translation unit compiles correctly. We will
keep the existing include structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
