songgaoye commented on code in PR #3702:
URL: https://github.com/apache/brpc/pull/3702#discussion_r4481581628
##########
src/brpc/redis_cluster.cpp:
##########
@@ -476,12 +476,12 @@ bool RedisClusterChannel::ExecuteMGet(const
ParsedCommand& cmd,
if (!ExecuteSingleCommand(sub_args, nullptr, &sub_result, cntl)) {
return false;
}
- values.push_back(sub_result.encoded_reply);
+ values.push_back(sub_result.encoded_reply.movable());
Review Comment:
IOBuf stores SmallView and BigView in the same union, and they are
explicitly guaranteed to have the same size. Thus:
```_sv = rhs.value()._sv```;
copies the entire union storage, not merely two BlockRefs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
