chenBright commented on code in PR #3709:
URL: https://github.com/apache/brpc/pull/3709#discussion_r4467116092
##########
src/bvar/reducer.h:
##########
@@ -351,6 +352,8 @@ class Reducer : public Variable {
private:
shared_combiner_type _combiner;
+ // `_combiner` keeps this ID allocated for the lifetime of the reducer.
+ const detail::AgentId _agent_id;
Review Comment:
The layout change is intentional, and the existing APIs remain unchanged.
Upgrades include rebuilding all consumers, including translation units
instantiating these templates, against matching headers. Binary compatibility
between objects built against different versions is not a requirement for this
change, so we will retain the cached member.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
