wasphin commented on PR #3690: URL: https://github.com/apache/brpc/pull/3690#issuecomment-6703537974
LGTM. The deferred-response lifecycle is still spread across several callbacks, and names such as AddIdleFailRef and OnSocketFailed could express their responsibilities more clearly. These can be handled in a focused follow-up refactor, together with the HTTP/HTTP2 ownership and error-handling boundaries, without expanding this PR further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
