I applied the patch. The change is safe and we know it fulfils Antoine's need for plugin testing.
(Assaf, feel free to jump in here if you see a better solution -- I didn't) alex On Wed, Sep 16, 2009 at 7:14 AM, Daniel Spiewak <[email protected]> wrote: > Assaf? I don't have the expertise to be authoritative here. > > Daniel > > On Wed, Sep 16, 2009 at 9:02 AM, Antoine Toulme <[email protected] > >wrote: > > > The patch is really just a one-liner. Can someone look into it please ? > > Thanks, > > > > Antoine > > > > On Fri, Sep 11, 2009 at 16:18, Antoine Toulme <[email protected] > > >wrote: > > > > > See BUILDR-312 for a patch that works for me. Please let me know if it > is > > > ok ? > > > Thanks, > > > > > > Antoine > > > > > > > > > On Fri, Sep 11, 2009 at 02:03, Antoine Toulme <[email protected] > > >wrote: > > > > > >> Yes, so can we do that a bit later so I get a chance to add my stuff > to > > >> the classpath ?Eventually, using a yield, or a block to do that would > > >> help me immensely. I'm fine providing a patch for it. > > >> > > >> Thanks, > > >> > > >> Antoine > > >> > > >> > > >> On Fri, Sep 11, 2009 at 01:35, Assaf Arkin <[email protected]> > wrote: > > >> > > >>> On Thu, Sep 10, 2009 at 4:11 PM, Antoine Toulme < > > [email protected]> > > >>> wrote: > > >>> > Hey guys, > > >>> > I'm building a buildr plugin and I test against the trunk of buildr > > >>> mounted > > >>> > as a braid mirror. > > >>> > > > >>> > Everything is ok so far (Daniel fixed BUILDR-309 yesterday). > > >>> > > > >>> > I have a small request: in sandbox.rb, Java.load is called. > > >>> > > > >>> > I have to call the buildr spec_helpers.rb before I can load my own > > >>> library. > > >>> > As a result, when used for specs, my code can't add things to the > > >>> classpath > > >>> > of Java for tests. > > >>> > > > >>> > I also wonder why this was done. After all, that means that for all > > the > > >>> > tests in all Buildr, the classpath is set once and for all ? > Couldn't > > >>> this > > >>> > be added to the sandbox method running before each command ? > > >>> > > >>> You can only load the JVM once. > > >>> > > >>> Assaf > > >>> > > >>> > > > >>> > Any idea as the best way to add stuff to the classpath in the specs > > >>> before > > >>> > sandbox locks up Java ? Could we do a before(:all) for it ? > > >>> > > > >>> > Thanks, > > >>> > > > >>> > Antoine > > >>> > > > >>> > > >> > > >> > > > > > >
