OK with me.

We could also centralize a few constants, like the jruby version, in a
central file. That's a different work though.

On Sun, Jul 24, 2011 at 19:13, Alex Boisvert <alex.boisv...@gmail.com>wrote:

> I think it's an improvement, so +1 from me.
>
> On Sun, Jul 24, 2011 at 5:20 AM, Peter Donald <pe...@realityforge.org
> >wrote:
>
> > Hi,
> >
> > I would like to make the ordering of the requires of internal buildr
> files
> > explicit. The aim being to simplify understanding and stop presenting the
> > illusion that you ca require files in the depths of buildr and have
> things
> > work. You can see the changeset as follows;
> >
> > https://github.com/realityforge/buildr/compare/trunk...unify-requires
> >
> > You will notice that almost all of the internal requires are ow in
> > lib/buildr.rb - the only exceptions being the scala/closure/groovy
> support
> > that still exist to make it possible to optionally load these. Requires
> > that
> > are common across the codebase were also pushed into this location.
> >
> > So what do you think? Is it worth applying?
> >
> > --
> > Cheers,
> >
> > Peter Donald
> >
>

Reply via email to