Hi,
On Sat, 2020-07-04 at 13:19 +0000, Benjamin Schubert wrote:
> Hey,
>
> Responses inline!
[...]
> > sources:
> > - kind: local
> > path: path/to/directory
> > include:
> > - *
> > exclude:
> > - /dev
> >
> > Since I've come across similar situations where I wanted to only stage
> > part of a source, I'm biased towards having it solved in core in a
> > generic way. And perhaps that is scope creep. So, I'd be curious to
> > hear what others think of this idea.
> >
>
> I like this idea, but I think that there are, in the end, orthogonal,
> though this one would also allow handling the other one.
I also consider this orthogonal, and think that it would be nice to
have pattern filtering moved to the core instead of only handling it in
some Source plugins, this would be more consistent with the existing
`path` attribute, and hopefully also allow removing the `directory`
attribute from `junction` elements (handling this generically from the
core might introduce a performance hit, though; it would be good if the
plugin had an opportunity to do the filtering, and fallback to generic
filtering for plugins which don't implement a filtering stage method).
I do really think it is a different thing though, specifying /paths/
(or subdirectories) to cherry pick in a source for staging, is
different from automatically excluding file /types/, inasmuch as the
feature being discussed initially here, does not require the user to
have intimate knowledge of the location of unsupported files within a
tarball (you don't have to know exactly where a dev node is; instead
things "just work").
> Would you see a reason why we would not want both?
>
Not me :)
Cheers,
-Tristan
