rmannibucau commented on code in PR #107:
URL: https://github.com/apache/bval/pull/107#discussion_r1564214812
##########
bval-jsr/src/main/java/org/apache/bval/jsr/metadata/Meta.java:
##########
@@ -354,11 +354,12 @@ public boolean equals(Object obj) {
if (!obj.getClass().equals(getClass())) {
Review Comment:
guess we would like to have a real equals/hashcode
what about just dropping both and use identity default impl, should be
sufficient since meta should be cached per reflection instance in bval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@bval.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
