And I discovered two more breakages from that change. SqlTypeFamily references java.sql.Types.TIMESTAMP_WITH_TIMEZONE, which doesn’t exist in JDK 1.7, which breaks the build under JDK 1.7.
And Long(long) constructor is deprecated in JDK 1.9, which generates a deprecation warning (which we treat as a build error) under JDK 1.9. I’ll fix them. But this close to the release, please run under JDK 1.7, 1.8 and 1.9, including javadoc and checking for deprecation warnings, before every commit. Julian > On Sep 7, 2017, at 1:50 PM, Jesus Camacho Rodriguez <jcama...@apache.org> > wrote: > > Julian, > > I cannot repro in my environment. Could you share the errors that you are > seeing? > > Thanks, > > -Jesús > > > > On 9/7/17, 1:12 PM, "Jesus Camacho Rodriguez" > <jcamachorodrig...@hortonworks.com on behalf of jcama...@apache.org> wrote: > >> Sure, let me take a look. >> >> -Jesús >> >> >> >> >> On 9/7/17, 10:44 AM, "Julian Hyde" <jh...@apache.org> wrote: >> >>> Jesus, >>> >>> I am seeing javadoc errors when I run "mvn site" (under JDK 1.8 on >>> Windows, as it happens) that are very likely from your CALCITE-1947 >>> commit. Can you fix ASAP. >>> >>> Julian >>> >> >
