Hi Julian,
That make sense. I'll update the script in a PR.
Regarding the gopher.png file, I removed it and replaced it with the
Calcite logo (you should be able to see the commit on master).
Are there any other changes that we need to make?
I am going to cancel the vote and tag 3.0.0-rc1 for voting.
Francis
On 21/04/2018 4:21 AM, Julian Hyde wrote:
I agree that the script to build the release should be part of the
source code. And the script that checks for headers is part of that.
The "case" statement is actually important, because it gives us a
place to document (and justify) files without headers, and other files
of interesting provenance.
Same goes for the 'how to' instructions.
Sometimes the release script and howto change during the release
process. It's not worth stopping a vote over that. They can be checked
in right after the release.
There are one or two changes that need to be made (e.g. the gopher
file). I think you should cancel this vote, roll another RC, and start
a new vote. Do you agree?
On Wed, Apr 18, 2018 at 8:08 PM, Francis Chuang
<francischu...@apache.org> wrote:
Hey Julian,
I was looking at integrating the script to exclude files without the license
header from the release artifacts. I don't think we will need to exclude
anything other than the files in the dist/ .git/ folders (which are already
ignored using tar --exclude), because all the files in the repo are required
to build the library and run its tests.
Regarding the gopher.png file, if the license is not acceptable, perhaps we
can use the logo of the Calcite project or the Apache Foundation. If that is
also not acceptable, I can update the code to generate some random bytes
during testing.
Francis
On 19/04/2018 11:47 AM, Julian Hyde wrote:
Thanks for starting the vote. A few questions/comments before I cast my
vote. Not all of them are release blockers, by any means.
I see there are tabs in the source code. Is this usual for go?
What is the purpose of gopher.png? Where did it come from? What is its
license?
Do you know what is the license of the files generated by protobuf?
Other than gopher.png, are there any other files in this release that have
been copied from elsewhere?
Would it be possible to add headers to all text files (even little files
like .gitignore)?
The tar command should probably drive from `git ls-files` so we don’t
accidentally include files that are lying around in the sandbox.
Let’s add the following to make-release-artifacts.sh:
for i in $(git ls-files); do
case "$i” in
(LICENSE|NOTICE);; # add exceptions here
(*) grep -q "Licensed to the Apache Software Foundation" $i || echo "$i
has no header”;;
esac
done
Julian
On Apr 18, 2018, at 3:37 PM, Francis Chuang <francischu...@apache.org>
wrote:
Thanks, Michael!
I opened a PR [1] to fix issues identified with the documentation and
site during the voting process.
Francis
[1] https://github.com/apache/calcite-avatica-go/pull/20
On 19/04/2018 12:22 AM, Michael Mior wrote:
+1 (binding) Thanks Frnacis!
One minor note: the manual instructions for testing say "go test-v"
(there's a space missing).
--
Michael Mior
mm...@uwaterloo.ca
2018-04-18 4:43 GMT-04:00 Francis Chuang <francischu...@apache.org>:
Hi all,
I have created a release for Apache Calcite Avatica Go, release
candidate
0.
The release notes are available here: https://github.com/apache/calc
ite-avatica-go/blob/master/site/go_history.md
The commit to be voted on: http://git-wip-us.apache.org/r
epos/asf/calcite-avatica-go/commit/cb2d4cb4596d5850bd0eb10c9
c7697b679aabc2d
The hash is cb2d4cb4596d5850bd0eb10c9c7697b679aabc2d
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcit
e-avatica-go-3.0.0-rc0/
The hashes of the artifacts are as follows:
src.tar.gz.md5 8B 76 54 78 3F 62 3C CF 56 BB CA F7 8F F3 F4 E6
src.tar.gz.sha256 476EAA2B 90E73BF7 98764F5B 48694E58 FC80FD8D 5EFC74B6
004DE7CB B1D4C0DE
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/jhyde.asc
Instructions for running the test suite is located here:
https://github.com/apache/calcite-avatica-go/blob/master/
site/go_development.md#testing
Please vote on releasing this package as Apache Calcite Avatica Go
3.0.0.
The vote is open for the next 72 hours and passes if a majority of
at least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite Avatica Go 3.0.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (non-binding)
Francis
