+1 (binding) Downloaded the source, checked hash and signature, checked (LICENSE, NOTICE, README), ran RAT, built and ran tests under JDK 8u172 and JDK 11 ea b22 on macOS, reviewed the release history notes as well.
Kevin Risden On Mon, Jul 16, 2018 at 8:33 PM, Julian Hyde <jh...@apache.org> wrote: > +1 (binding) > > Downloaded; checked hashes; checked LICENSE, NOTICE, README; ran RAT; > built and ran tests under JDK 9 on macOS; read release notes. > > I also built and ran tests on Windows Server 2012. > > Volodymyr, > > Thanks being release manager. You made this run very smoothly! > > Before we announce the release, you should get your key signed by someone > in the web of trust, and add it to http://www.apache.org/dist/calcite/KEYS > <http://www.apache.org/dist/calcite/KEYS>. This does not affect my vote > on this release candidate. > > Julian > > > > On Jul 16, 2018, at 8:33 AM, Enrico Olivelli <eolive...@gmail.com> > wrote: > > > > +1 (non binding) > > Checked checksums, Apache RAT and signatures on source candidate package > > Run tests on Oracle JDK 8 on Fedora 26 without issues > > Run unit tests of downstream project HerdDB without issues > > > > Great work ! > > > > Beside question: > > I needed to import https://people.apache.org/ > keys/committer/volodymyr.asc > > isn't there a common official Apache Calcite repository for KEYS ? > > > > > > Enrico > > > > > > > > Il giorno lun 16 lug 2018 alle ore 15:56 Sergey Nuyanzin < > > snuyan...@gmail.com> ha scritto: > > > >> +1 (non-binding) > >> - downloaded, checked gpg and sha256 > >> - compiled and ran tests ("mvn clean install") using JDK 8_162, 10.0.1 > on > >> Fedora and Windows > >> - ran simple queries via sqlline > >> > >> On Mon, Jul 16, 2018 at 12:52 PM, Volodymyr Vysotskyi < > >> volody...@apache.org> > >> wrote: > >> > >>> Hi all, > >>> > >>> I have created a build for Apache Calcite 1.17.0, release candidate 0. > >>> > >>> Thanks to everyone who has contributed to this release. > >>> You can read the release notes here: > >>> https://github.com/apache/calcite/blob/branch-1.17/site/ > _docs/history.md > >>> > >>> The commit to be voted upon: > >>> https://git-wip-us.apache.org/repos/asf/calcite/commit/c2b3a > >>> 995bfcf4eee31521dd1b557ca722112914e > >>> > >>> Its hash is c2b3a995bfcf4eee31521dd1b557ca722112914e. > >>> > >>> The artifacts to be voted on are located here: > >>> > >> https://dist.apache.org/repos/dist/dev/calcite/apache- > calcite-1.17.0-rc0/ > >>> > >>> The hashes of the artifacts are as follows: > >>> src.tar.gz.sha256 > >>> 7caf5cc16815836d643e58748b63f9ee7df3fb4d1edf30ac0e7ba17685f6844e > >>> > >>> A staged Maven repository is available for review at: > >>> https://repository.apache.org/content/repositories/ > orgapachecalcite-1044 > >>> > >>> Release artifacts are signed with the following key: > >>> https://people.apache.org/keys/committer/volodymyr.asc > >>> > >>> Please vote on releasing this package as Apache Calcite 1.17.0. > >>> > >>> The vote is open for the next 72 hours and passes if a majority of > >>> at least three +1 PMC votes are cast. > >>> > >>> [ ] +1 Release this package as Apache Calcite 1.17.0 > >>> [ ] 0 I don't feel strongly about it, but I'm okay with the release > >>> [ ] -1 Do not release this package because... > >>> > >>> > >>> Here is my vote: > >>> > >>> +1 (binding) > >>> > >>> Kind regards, > >>> Volodymyr Vysotskyi > >>> > >> > >> > >> > >> -- > >> Best regards, > >> Sergey > >> > >
